Re: [Qemu-devel] [PATCH v2 20/22] tcg: Save insn data and use it in cpu_restore_state_from_tb

[Peter Maydell]

On 18 September 2015 at 05:55, Richard Henderson <address@hidden> wrote:
> We can now restore state without retranslation.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> +/* Encode the data collected about the instructions while compiling TB.
> +   Place the data at BLOCK, and return the number of bytes consumed.
> +
> +   The logical table consisits of TARGET_INSN_START_WORDS target_ulong's,

"consists". No apostrophe in 'target_ulongs'.

> +   which come from the target's insn_start data, followed by a uintptr_t
> +   which comes from the host pc of the end of the code implementing the insn.
> +
> +   Each line of the table is encoded as sleb128 deltas from the previous
> +   line.  The seed for the first line is { tb->pc, 0..., tb->tc_ptr }.
> +   That is, the first column is seeded with the guest pc, the last column
> +   with the host pc, and the middle columns with zeros.  */

You're still not allowing for your worst-case datatable size when we
calculate tcg_ctx.code_gen_buffer_max_size.

Otherwise looks OK.

thanks
-- PMM