qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of mult


From: Jonathan Neuschäfer
Subject: Re: [Qemu-devel] [PATCH] linux-user: fix cmsg conversion in case of multiple headers
Date: Mon, 21 Sep 2015 07:34:15 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Fri, Sep 04, 2015 at 01:48:39PM +0100, Peter Maydell wrote:
> On 3 September 2015 at 06:27, Jonathan Neuschäfer <address@hidden> wrote:
> > Currently, __target_cmsg_nxthdr compares a pointer derived from
> > target_cmsg against the msg_control field of target_msgh (through
> > subtraction).  This failed for me when emulating i386 code under x86_64,
> > because pointers in the host address space and pointers in the guest
> > address space were not the same.  This patch passes the initial value of
> > target_cmsg into __target_cmsg_nxthdr.
> >
> > I found and fixed two more related bugs:
> > - __target_cmsg_nxthdr now returns the new cmsg pointer instead of the
> >   old one.
> > - tgt_space (in host_to_target_cmsg) doesn't count "sizeof (struct
> >   target_cmsghdr)" twice anymore.
> >
> > Signed-off-by: Jonathan Neuschäfer <address@hidden>
> 
> Reviewed-by: Peter Maydell <address@hidden>

Ping.

What's the status of this patch?


Regards,
Jonathan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]