qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v11 04/12] net: merge qemu_deliver_packet and qe


From: Yang Hongyang
Subject: Re: [Qemu-devel] [PATCH v11 04/12] net: merge qemu_deliver_packet and qemu_deliver_packet_iov
Date: Tue, 22 Sep 2015 17:26:35 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 09/22/2015 05:19 PM, Jason Wang wrote:
[...]

If we drop this patch, we will need to introduce 2 deliver func, which
seems not clean and simple.

Then you can probably skip the iov_to_buf() if iov_cnt is one in the
above code?

Seems like a good idea to avoid the extra memcpy, thank you! BTW,
can I do this on top of the series if there's no other comments?

Better squash the changes in this patch or another independent patch
before this patch. (We don't want to break bisection).

so that the first 10 patch can be merged as is. if not, I will send
another
version v12 to fix this.

Post V12 or if you wish, I can fix this myself :)

It's great if you can fix this, then I can focus on the multiqueue
support later, thanks a lot for the help! :)


Thanks


.


--
Thanks,
Yang.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]