[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 10/19] vfio/pci: Foundation for new quirk structu
From: |
Alex Williamson |
Subject: |
Re: [Qemu-devel] [PULL 10/19] vfio/pci: Foundation for new quirk structure |
Date: |
Wed, 23 Sep 2015 21:22:28 -0600 |
On Thu, 2015-09-24 at 10:54 +0800, Wen Congyang wrote:
> On 09/24/2015 04:23 AM, Alex Williamson wrote:
> > @@ -275,12 +276,15 @@ static void
> > vfio_vga_probe_ati_3c3_quirk(VFIOPCIDevice *vdev)
> > }
> >
> > quirk = g_malloc0(sizeof(*quirk));
> > - quirk->vdev = vdev;
> > + legacy = quirk->data = g_malloc0(sizeof(*legacy));
> > + quirk->mem = legacy->mem = g_malloc0_n(sizeof(MemoryRegion), 1);
>
> Why do you use g_malloc0_n() here? It is introduced in glib 2.24, but we only
> require glib 2.22.
Because I saw it, I guess in scripts/coverity-model.c, and used it. In
this particular instance it seems irrelevant, but VFIOQuirk.mem points
to an array of MemoryRegions, other users here have more than one array
entry and I chose to use the same allocator throughout for consistency.
What's the preferred helper here, simply calloc()? Thanks,
Alex
- [Qemu-devel] [PULL 03/19] vfio/pci: Rename INTx functions for easier tracing, (continued)
- [Qemu-devel] [PULL 03/19] vfio/pci: Rename INTx functions for easier tracing, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 04/19] vfio/pci: Rename MSI/X functions for easier tracing, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 05/19] vfio/pci: Make interrupt bypass runtime configurable, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 06/19] vfio: Change polarity of our no-mmap option, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 07/19] vfio/pci: Extract PCI structures to a separate header, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 09/19] vfio/pci: Cleanup ROM blacklist quirk, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 08/19] vfio/pci: Split quirks to a separate file, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 11/19] vfio/pci: Cleanup ATI 0x3c3 quirk, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 10/19] vfio/pci: Foundation for new quirk structure, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 12/19] vfio/pci: Cleanup Nvidia 0x3d0 quirk, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 13/19] vfio/pci: Rework RTL8168 quirk, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 14/19] vfio/pci: Config window quirks, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 15/19] vfio/pci: Config mirror quirk, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 16/19] vfio/pci: Remove old config window and mirror quirks, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 17/19] vfio/pci: Move AMD device specific reset to quirks, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 18/19] vfio/pci: Cache vendor and device ID, Alex Williamson, 2015/09/23
- [Qemu-devel] [PULL 19/19] vfio/pci: Add emulated PCI IDs, Alex Williamson, 2015/09/23
- Re: [Qemu-devel] [PULL 00/19] VFIO updates, Peter Maydell, 2015/09/23