[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter |
Date: |
Fri, 25 Sep 2015 10:18:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 25/09/15 10:03, Yang Hongyang wrote:
>
>
> On 09/24/2015 05:12 PM, Markus Armbruster wrote:
>> Yang Hongyang <address@hidden> writes:
> [...]
>>> diff --git a/vl.c b/vl.c
>>> index ec589e2..3cf89d5 100644
>>> --- a/vl.c
>>> +++ b/vl.c
>>> @@ -2794,7 +2794,12 @@ static bool object_create_initial(const char
>>> *type)
>>> if (g_str_equal(type, "rng-egd")) {
>>> return false;
>>> }
>>> - /* TODO: return false for concrete netfilters */
>>> +
>>> + /* return false for concrete netfilters */
>>
>> I find this comment useless, please drop it :)
>
> This might be useful for reminding others who wants to implement other
> filters.
I think the comment should explain why the code is return false here,
not what the code is doing (which is obvious). So maybe something like:
/*
* netfilters require that the corresponding
* netdevs are already existing
*/
?
Thomas
- Re: [Qemu-devel] [PATCH v11 12/12] netfilter: add multiqueue support, (continued)
- Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter, Yang Hongyang, 2015/09/25
- Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter,
Thomas Huth <=
- Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter, Yang Hongyang, 2015/09/25
- Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter, Markus Armbruster, 2015/09/25
- Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter, Yang Hongyang, 2015/09/28
[Qemu-devel] [PATCH v11 11/12] netfilter/multiqueue: introduce netfilter name, Yang Hongyang, 2015/09/16
Re: [Qemu-devel] [PATCH v11 00/12] Add a netfilter object and netbuffer filter, Jason Wang, 2015/09/22
Re: [Qemu-devel] [PATCH v11 00/12] Add a netfilter object and netbuffer filter, Jason Wang, 2015/09/24