[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/7] cutils: Normalize qemu_strto[u]ll() signatu
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH 6/7] cutils: Normalize qemu_strto[u]ll() signature |
|
Date: |
Fri, 25 Sep 2015 14:44:08 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
Am 25.09.2015 um 14:42 schrieb Paolo Bonzini:
> On 25/09/2015 14:39, Andreas Färber wrote:
>> Instead of using int64_t for qemu_strtoll() and uiint64_t for
>> qemu_strtoull(), use long long and unsigned long long as their name
>> implies.
>>
>> The only affected callers are our test cases.
>>
>> This prepares for following checkpatch's recommendation of using it more,
>> by making it easier to switch from POSIX to QEMU versions.
>> Remaining difference is const-ness.
>
> Do we actually use long long and unsigned long long anywhere?
The next patch does, because checkpatch asks for it. :)
qemu_strtoull() has some special handling for Windows apparently.
Cheers,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
- [Qemu-devel] [PATCH 2/7] test-string-input-visitor: Add int test case, (continued)
- [Qemu-devel] [PATCH 2/7] test-string-input-visitor: Add int test case, Andreas Färber, 2015/09/25
- [Qemu-devel] [PATCH 1/7] string-input-visitor: Fix uint64 parsing, Andreas Färber, 2015/09/25
- [Qemu-devel] [PATCH 5/7] tests: Add scsi-disk test, Andreas Färber, 2015/09/25
- [Qemu-devel] [PATCH 4/7] tests: Add QOM property unit tests, Andreas Färber, 2015/09/25
- [Qemu-devel] [PATCH 6/7] cutils: Normalize qemu_strto[u]ll() signature, Andreas Färber, 2015/09/25
Re: [Qemu-devel] [PATCH 6/7] cutils: Normalize qemu_strto[u]ll() signature, Eric Blake, 2015/09/25