[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/11] virtio-gpu: move iov free to virtio_gp
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 04/11] virtio-gpu: move iov free to virtio_gpu_cleanup_mapping_iov |
|
Date: |
Fri, 25 Sep 2015 15:14:59 +0200 |
On Do, 2015-09-24 at 13:16 +0300, Michael S. Tsirkin wrote:
> On Thu, Sep 24, 2015 at 11:04:55AM +0200, Gerd Hoffmann wrote:
> > Signed-off-by: Gerd Hoffmann <address@hidden>
>
> It's easy to see this is what the patch does. But why? Some
> explanation in the commit log about why it's done, as opposed to what is
> done, would be better.
It's for symmetry reasons: virtio_gpu_create_mapping_iov() allocates it
so virtio_gpu_cleanup_mapping_iov() should free it, otherwise it's easy
to miss a free() needed and leak memory.
cheers,
Gerd
- [Qemu-devel] [PATCH v2 00/11] add virgl rendering support, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [PATCH v2 02/11] sdl2: stop flickering, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [PATCH v2 03/11] ui/console: add opengl context and scanout support interfaces., Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [PATCH v2 04/11] virtio-gpu: move iov free to virtio_gpu_cleanup_mapping_iov, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [PATCH v2 01/11] shaders: initialize vertexes once, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [PATCH v2 09/11] opengl: add egl-context.[ch] helpers, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [PATCH v2 06/11] virtio-gpu: update headers for virgl/3d, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [PATCH v2 08/11] sdl2/opengl: add opengl context and scanout support, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [PATCH v2 05/11] virtio-gpu: change licence from GPLv2 to GPLv2+, Gerd Hoffmann, 2015/09/24
- [Qemu-devel] [PATCH v2 10/11] gtk/opengl: add opengl context and scanout support (egl), Gerd Hoffmann, 2015/09/24