[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 5/6] monitor: Throttle event VSERPORT_CHANGE separ
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC 5/6] monitor: Throttle event VSERPORT_CHANGE separately by "id" |
Date: |
Fri, 25 Sep 2015 13:24:12 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/25/2015 08:00 AM, Markus Armbruster wrote:
> VSERPORT_CHANGE is emitted when the guest opens or closes a
> virtio-serial port. The event's member "id" identifies the port.
>
> When several events arrive quickly, throttling drops all but the last
> of them. Because of that, a QMP client must assume that *any* port
> may have changed state when it receives a VSERPORT_CHANGE event and
> throttling may have happened.
>
> Make the event more useful by throttling it for each port separately.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> monitor.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
All future differentiation would be added as additional special cases
within the hash functions, but I like this approach for keeping the rest
of the algorithm independent from what the hashing considers as equivalent.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [RFC 4/6] monitor: Turn monitor_qapi_event_state[] into a hash table, (continued)
- [Qemu-devel] [RFC 3/6] monitor: Split MonitorQAPIEventConf off MonitorQAPIEventState, Markus Armbruster, 2015/09/25
- [Qemu-devel] [RFC 1/6] monitor: Reduce casting of QAPI event QDict, Markus Armbruster, 2015/09/25
- [Qemu-devel] [RFC 2/6] monitor: Simplify event throttling, Markus Armbruster, 2015/09/25
- [Qemu-devel] [RFC 5/6] monitor: Throttle event VSERPORT_CHANGE separately by "id", Markus Armbruster, 2015/09/25
- Re: [Qemu-devel] [RFC 5/6] monitor: Throttle event VSERPORT_CHANGE separately by "id",
Eric Blake <=
- Re: [Qemu-devel] [RFC 0/6] Throttle event VSERPORT_CHANGE separately by "id", Marc-André Lureau, 2015/09/25
- [Qemu-devel] [RFC 6/6] docs: Document QMP event rate limiting, Markus Armbruster, 2015/09/25