Re: [Qemu-devel] [PATCH V2] vnc: destroy server surface if no client is connected

[Peter Lieven]

> Am 29.09.2015 um 14:49 schrieb Gerd Hoffmann <address@hidden>:
> 
> On Di, 2015-09-29 at 14:41 +0200, Peter Lieven wrote:
>>> Am 29.09.2015 um 12:28 schrieb Gerd Hoffmann <address@hidden>:
>>> 
>>> Hi,
>>> 
>>>> -    graphic_hw_update(vd->dcl.con);
>>>> +    if (first_client) {
>>>> +        /* set/restore the correct surface in the VNC server */
>>>> +        console_select(0);
>>> 
>>> Nah, that has unwanted side effects.
>> 
>> okay, ill try to respin without this hack.
>> 
>>> 
>>> Pushed some patches to git://git.kraxel.org/qemu rebase/ui-vnc-next,
>>> could you have a look?
>> 
>> if you mean the RFC patches on the list I already send a bunch of comments 
>> on them.
> 
> It's updated, taking your comments in account, reworking the server
> surface code so we can free it without clients, also added
> qio_buffer_shrink() but added no calls yet.
> 

had a quick look (without testing).

what about Recycling the output buffer as worker thread buffer?

about shrinking: I had the idea to count the number of times the buffer was 
(significantly) too big and only shrink if that counter has reached a 
reasonable value. and reset that counter to zero if the buffer has the right 
size.

i would check this in qio_buffer_resize. as you suggested earlier.

Peter 


> cheers,
>  Gerd
> 
>