[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler
|
From: |
Aneesh Kumar K.V |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/3] virtio-9p: add unrealize handler |
|
Date: |
Wed, 07 Oct 2015 14:20:28 +0530 |
|
User-agent: |
Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) |
Stefan Hajnoczi <address@hidden> writes:
> On Mon, Oct 05, 2015 at 11:07:23AM +0200, Greg Kurz wrote:
>> If the user tries to hot unplug a virtio-9p device, it seems to succeed but
>> in fact:
>> - virtio-9p coroutines thread pool and async queue are leaked
>> - QEMU crashes in virtio_vmstate_change() if the user tries to live migrate
>>
>> This patch brings hot unplug support to virtio-9p-device. It fixes both
>> above issues.
>>
>> Signed-off-by: Greg Kurz <address@hidden>
>> ---
>> hw/9pfs/virtio-9p-device.c | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>
> What happens to in-flight I/O requests? We cannot assume that the guest
> driver quiesces the device.
We enable migration blocker when we have an active mount. So if we get
here, that should indicate no active 9p mounts.
-aneesh