[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2] fw_cfg: Define a static signature to be retur
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCHv2] fw_cfg: Define a static signature to be returned on DMA port reads |
|
Date: |
Tue, 6 Oct 2015 09:04:43 +0100 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Oct 05, 2015 at 07:51:55PM -0400, Kevin O'Connor wrote:
> +static uint64_t fw_cfg_dma_mem_read(void *opaque, hwaddr addr,
> + unsigned size)
> +{
> + // Return a signature value (and handle various read sizes)
> + return extract64(FW_CFG_DMA_SIGNATURE, (8 - addr - size) * 8, size*8);
Perhaps the maintainer can s/size*8/size * 8/ when applying this patch.
Reviewed-by: Stefan Hajnoczi <address@hidden>