qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] doc: document ivshmem & hugepages


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] doc: document ivshmem & hugepages
Date: Wed, 7 Oct 2015 09:12:35 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 10/07/2015 08:32 AM, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
> 
> Document and give some examples of hugepages support with ivshmem device
> and server.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  qemu-doc.texi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index afa2263..b15c14c 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -1293,6 +1293,19 @@ copy the shared memory on migration to the destination 
> host.  With
>  With the @option{peer} case, the device should be detached and then 
> reattached
>  after migration using the PCI hotplug support.
>  
> address@hidden ivshmem & hugepages

s/&/and/ (documentation looks a bit too casual if you don't spell out
conjunctions)

> +
> +Instead of specifying the <shm size> using POSIX shm, you may specify
> +a memory backend, that has hugepage support:

s/backend,/backend/

With those two fixes, the grammar is:
Reviewed-by: Eric Blake <address@hidden>

I don't know if it is technically accurate, though.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]