[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 1/1] block/gluster: add support for multiple
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v5 1/1] block/gluster: add support for multiple gluster backup volfile servers |
Date: |
Wed, 7 Oct 2015 11:38:30 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 07.10.2015 um 11:09 hat Peter Krempa geschrieben:
> On Mon, Sep 28, 2015 at 18:06:12 +0530, Prasanna Kumar Kalever wrote:
> > driver => 'gluster' (protocol name)
> > volname => name of gluster volume where our VM image resides
> > image-path => is the absolute path of image in gluster volume
> >
> > {tuple} => {"server":"1.2.3.4"[,"port":"24007","transport":"tcp"]}
> >
> > server => server address (hostname/ipv4/ipv6 addresses)
> > port => port number on which glusterd is listening. (default
> > 24007)
> > tranport => transport type used to connect to gluster management
> > daemon,
> > it can be tcp|rdma (default 'tcp')
> >
> > Examples:
> > 1.
> > -drive driver=qcow2,file.driver=gluster,
> > file.volname=testvol,file.image-path=/path/a.qcow2,
> > file.volfile-servers.0.server=1.2.3.4,
> > file.volfile-servers.0.port=24007,
> > file.volfile-servers.0.transport=tcp,
> > file.volfile-servers.1.server=5.6.7.8,
> > file.volfile-servers.1.port=24008,
> > file.volfile-servers.1.transport=rdma
> > 2.
> > 'json:{"driver":"qcow2","file":{"driver":"gluster","volname":"testvol",
> > "image-path":"/path/a.qcow2","volfile-servers":
> > [{"server":"1.2.3.4","port":"24007","transport":"tcp"},
> > {"server":"4.5.6.7","port":"24008","transport":"rdma"}] } }'
>
> -drive driver=qcow2,file.driver=gluster,
> file.volume=testvol,
> file.path=/path/a.qcow2,
> file.server.0.host=1.2.3.4,
> file.server.0.port=24007,
> file.server.0.transport=tcp,
> file.server.1.host=5.6.7.8,
> file.server.1.port=24008,
> file.server.1.transport=rdma
>
> I'm suggesting the above naming scheme.
> So:
> 'path' instead of 'image-path'
> 'volume' instead of 'volname'
> 'server' instead of 'volfile-servers'
> 'host' instead of 'server'
I agree, let's keep the names short so they are easy to read, type and
remember. I especially agree with changing 'server' into 'host' because
that makes it consistent with InetSocketAddress.
Kevin
pgpHZhIpv_caX.pgp
Description: PGP signature