[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH] qapi: split visit_end_struct() into pieces
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH] qapi: split visit_end_struct() into pieces |
|
Date: |
Wed, 07 Oct 2015 15:08:32 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Markus Armbruster <address@hidden> writes:
> Eric Blake <address@hidden> writes:
[...]
>> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
>> index c419b17..48867c4 100644
>> --- a/hw/virtio/virtio-balloon.c
>> +++ b/hw/virtio/virtio-balloon.c
>> @@ -132,14 +132,16 @@ static void balloon_stats_get_all(Object *obj, struct
>> Visitor *v,
> visit_start_struct(v, NULL, NULL, "stats", 0, &err);
> if (err) {
> goto out_end;
> }
> for (i = 0; !err && i < VIRTIO_BALLOON_S_NR; i++) {
>> visit_type_int64(v, (int64_t *) &s->stats[i], balloon_stat_names[i],
>> &err);
>
> Preexisting: if visit_type_int64() fails, we need to break the loop.
> Separate fix.
Nonsense.
[...]