[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?
From: |
Pavel Dovgaluk |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed? |
Date: |
Wed, 7 Oct 2015 12:37:16 +0300 |
I checked this patch.
Let's leave it without runstate_is_running() call.
If it will be needed later, we'll find it out.
Pavel Dovgalyuk
> -----Original Message-----
> From: Paolo Bonzini [mailto:address@hidden On Behalf Of Paolo Bonzini
> Sent: Tuesday, October 06, 2015 11:01 PM
> To: address@hidden
> Cc: address@hidden
> Subject: [PATCH 3/4] why is runstate_is_running needed?
>
> It doesn't seem correct to call it for all checkpoints, but why
> is it right for timerlist_run_timers?
> ---
> qemu-timer.c | 9 +++------
> stubs/replay.c | 5 -----
> 2 files changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/qemu-timer.c b/qemu-timer.c
> index 3c6e4c3..f16e422 100644
> --- a/qemu-timer.c
> +++ b/qemu-timer.c
> @@ -488,20 +488,17 @@ bool timerlist_run_timers(QEMUTimerList *timer_list)
> break;
> default:
> case QEMU_CLOCK_VIRTUAL:
> - if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running())
> - || !replay_checkpoint(CHECKPOINT_CLOCK_VIRTUAL)) {
> + if (!replay_checkpoint(CHECKPOINT_CLOCK_VIRTUAL)) {
> goto out;
> }
> break;
> case QEMU_CLOCK_HOST:
> - if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running())
> - || !replay_checkpoint(CHECKPOINT_CLOCK_HOST)) {
> + if (!replay_checkpoint(CHECKPOINT_CLOCK_HOST)) {
> goto out;
> }
> break;
> case QEMU_CLOCK_VIRTUAL_RT:
> - if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running())
> - || !replay_checkpoint(CHECKPOINT_CLOCK_VIRTUAL_RT)) {
> + if (!replay_checkpoint(CHECKPOINT_CLOCK_VIRTUAL_RT)) {
> goto out;
> }
> break;
> diff --git a/stubs/replay.c b/stubs/replay.c
> index 71fa7d5..42d01b5 100755
> --- a/stubs/replay.c
> +++ b/stubs/replay.c
> @@ -22,11 +22,6 @@ bool replay_checkpoint(ReplayCheckpoint checkpoint)
> return true;
> }
>
> -int runstate_is_running(void)
> -{
> - abort();
> -}
> -
> bool replay_events_enabled(void)
> {
> return false;
> --
> 2.5.0
>
- Re: [Qemu-devel] [PATCH 4/4] events doubts, (continued)
- Re: [Qemu-devel] [PATCH 4/4] events doubts, Paolo Bonzini, 2015/10/08
- Re: [Qemu-devel] [PATCH 4/4] events doubts, Pavel Dovgaluk, 2015/10/08
- Re: [Qemu-devel] [PATCH 4/4] events doubts, Paolo Bonzini, 2015/10/08
- Re: [Qemu-devel] [PATCH 4/4] events doubts, Pavel Dovgaluk, 2015/10/08
- Re: [Qemu-devel] [PATCH 4/4] events doubts, Paolo Bonzini, 2015/10/08
[Qemu-devel] [PATCH 1/4] replay: generalize ptimer event to bottom halves, Paolo Bonzini, 2015/10/08
[Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?, Paolo Bonzini, 2015/10/08
[Qemu-devel] [PATCH 2/4] more replay fixes, Paolo Bonzini, 2015/10/08
Re: [Qemu-devel] [RFH PATCH 0/4] record/replay fixups and doubts, Pavel Dovgaluk, 2015/10/13
Re: [Qemu-devel] [RFH PATCH 0/4] record/replay fixups and doubts, Pavel Dovgaluk, 2015/10/23