[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/12] aio: Introduce "type" in aio_set_fd_handl
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 01/12] aio: Introduce "type" in aio_set_fd_handler and aio_set_event_notifier |
Date: |
Fri, 9 Oct 2015 16:08:29 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 09.10.2015 um 07:45 hat Fam Zheng geschrieben:
> The parameter is added but not used.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> aio-posix.c | 4 ++-
> aio-win32.c | 2 ++
> async.c | 3 ++-
> block/curl.c | 14 +++++-----
> block/iscsi.c | 9 +++----
> block/linux-aio.c | 5 ++--
> block/nbd-client.c | 10 ++++---
> block/nfs.c | 17 +++++-------
> block/sheepdog.c | 38 ++++++++++++++++++---------
> block/ssh.c | 5 ++--
> block/win32-aio.c | 5 ++--
> hw/block/dataplane/virtio-blk.c | 6 +++--
> hw/scsi/virtio-scsi-dataplane.c | 24 +++++++++++------
> include/block/aio.h | 5 ++++
> iohandler.c | 3 ++-
> nbd.c | 4 ++-
> roms/ipxe | 2 +-
This one looks unrelated.
> tests/test-aio.c | 58
> +++++++++++++++++++++++------------------
> 18 files changed, 129 insertions(+), 85 deletions(-)
> diff --git a/include/block/aio.h b/include/block/aio.h
> index 400b1b0..830a0e8 100644
> --- a/include/block/aio.h
> +++ b/include/block/aio.h
> @@ -275,6 +275,9 @@ bool aio_pending(AioContext *ctx);
> */
> bool aio_dispatch(AioContext *ctx);
>
> +#define AIO_CLIENT_UNSPECIFIED (1 << 0)
> +#define AIO_CLIENT_MASK_ALL -1
> +
> /* Progress in completing AIO work to occur. This can issue new pending
> * aio as a result of executing I/O completion or bh callbacks.
> *
> @@ -299,6 +302,7 @@ bool aio_poll(AioContext *ctx, bool blocking);
> */
> void aio_set_fd_handler(AioContext *ctx,
> int fd,
> + int type,
> IOHandler *io_read,
> IOHandler *io_write,
> void *opaque);
> @@ -312,6 +316,7 @@ void aio_set_fd_handler(AioContext *ctx,
> */
> void aio_set_event_notifier(AioContext *ctx,
> EventNotifier *notifier,
> + int type,
> EventNotifierHandler *io_read);
I'll leave the details like that AIO_CLIENT_MASK_ALL depends on two's
complement representation to László, but as a matter of personal taste,
I'd still prefer unsigned types for bitmasks.
I would still give my R-b if it weren't for the submodule change.
Kevin
- [Qemu-devel] [PATCH 02/12] aio: Save fd client type to AioHandler, (continued)
- [Qemu-devel] [PATCH 02/12] aio: Save fd client type to AioHandler, Fam Zheng, 2015/10/09
- [Qemu-devel] [PATCH 03/12] nbd: Mark fd handlers client type as "external", Fam Zheng, 2015/10/09
- [Qemu-devel] [PATCH 07/12] block: Add "drained begin/end" for transactional external snapshot, Fam Zheng, 2015/10/09
- [Qemu-devel] [PATCH 10/12] block: Add "drained begin/end" for internal snapshot, Fam Zheng, 2015/10/09
- [Qemu-devel] [PATCH 11/12] block: Introduce BlockDriver.bdrv_drain callback, Fam Zheng, 2015/10/09
- [Qemu-devel] [PATCH 08/12] block: Add "drained begin/end" for transactional backup, Fam Zheng, 2015/10/09
- [Qemu-devel] [PATCH 06/12] block: Introduce "drained begin/end" API, Fam Zheng, 2015/10/09
- [Qemu-devel] [PATCH 01/12] aio: Introduce "type" in aio_set_fd_handler and aio_set_event_notifier, Fam Zheng, 2015/10/09
- Re: [Qemu-devel] [PATCH 01/12] aio: Introduce "type" in aio_set_fd_handler and aio_set_event_notifier,
Kevin Wolf <=
- [Qemu-devel] [PATCH 05/12] aio: introduce aio_{disable, enable}_clients, Fam Zheng, 2015/10/09
[Qemu-devel] [PATCH 09/12] block: Add "drained begin/end" for transactional blockdev-backup, Fam Zheng, 2015/10/09
[Qemu-devel] [PATCH 04/12] dataplane: Mark host notifiers' client type as "external", Fam Zheng, 2015/10/10
[Qemu-devel] [PATCH 12/12] qed: Implement .bdrv_drain, Fam Zheng, 2015/10/10