[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-tilegx: Let prefetch nop instructions re
From: |
Chen Gang |
Subject: |
Re: [Qemu-devel] [PATCH] target-tilegx: Let prefetch nop instructions return before allocating dest temporary register |
Date: |
Sun, 11 Oct 2015 00:12:36 +0800 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
Hello all:
It looks I have to spend quite a few free time resources on tilegx gcc
testsuite issues, next (may 2-3 months at least, I guess).
So for tilegx qemu, I guess, I need to start to implement the floating
point, at present. I shall try to finish within this month (although it
seems not quite easy to me).
By the way, excuse me, my English is not quite well, so:
- I have to try to 'speak' as clearly as I can, so sometimes what I
said may be not quite polite, please understand.
- If any members find any issues/bugs which may be related with me,
please say directly and clearly (or sometimes, I maybe misunderstand,
then waste our time resources).
Thanks.
On 10/10/15 06:50, Chen Gang wrote:
>
> On 10/10/15 06:10, Richard Henderson wrote:
>> On 10/09/2015 09:48 AM, Chen Gang wrote:
>>> On 10/7/15 18:17, Chen Gang wrote:
>>>> On 10/7/15 17:19, Richard Henderson wrote:
>>>>> On 10/04/2015 10:15 PM, Chen Gang wrote:
>>>>>>> From 40ec3f1c75b4c97e3e0495c9e465be898f48a652 Mon Sep 17 00:00:00 2001
>>>>>> From: Chen Gang<address@hidden>
>>>>>> Date: Sun, 4 Oct 2015 17:34:17 +0800
>>>>>> Subject: [PATCH] target-tilegx: Let prefetch nop instructions return
>>>>>> before allocating dest temporary register
>>>>>>
>>>>>> Or it will cause issue by the dest temporary registers.
>>>>>>
>>>>>> Signed-off-by: Chen Gang<address@hidden>
>>>>>> ---
>>>>>> target-tilegx/translate.c | 85
>>>>>> +++++++++++++++++++++++++----------------------
>>>>>> 1 file changed, 46 insertions(+), 39 deletions(-)
>>>>>
>>>>> Isn't my patch 14/14 from the last patch set sufficient?
>>>>>
>>>
>>> At present, all patches (include 14/14) are integrated into master tree,
>>> so I guess, we have to integrate this patch into master tree next, it
>>> fix the dest temporary registers' issue.
>>
>> What issue? The prefetch instructions "load" to the zero register,
>> which is never written back to the register file.
>>
>
> OK, really. But for me, the code is very easy to lead other members to
> make mistakes.
>
> Thanks.
>
--
Chen Gang (陈刚)
Open, share, and attitude like air, water, and life which God blessed