Re: [Qemu-devel] [PATCH 0/3] Use glib 2.26 version macros

[John Snow]

On 10/12/2015 08:38 AM, Peter Maydell wrote:
> On 12 October 2015 at 13:31, Daniel P. Berrange <address@hidden> wrote:
>> On Mon, Oct 12, 2015 at 02:24:36PM +0200, Marc-André Lureau wrote:
>>> What about just using the macro, but not bumping glib requirement?
>>
>> It would be desirable -  I think someone explored using the GLIB_VERSION
>> macros before, without bumping version. I can't remember what the problem
>> was that made them abandon that though - maybe someone else recalls...
> 
> I think that was David Gilbert, and I vaguely recall there being
> bad interactions with our glib-compat.h header.
> 
> -- PMM
> 

The version check macros will complain about our back-porting of glib
functions as seen in glib-compat, yes. I think David Gilbert and I each
had a stab at it.

It's fine if you're running 2.22 or so, but if you are running a more
modern version that actually provides the functions we backport/emulate,
the version check macros will catch that and set an error.

Not sure if there's some sort of squelch mechanism. "I know I told you
to complain if I use a 2.23+ function, but forgive me just this once."

--js