[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] target-i386: allow any alignment for SMBASE
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH] target-i386: allow any alignment for SMBASE |
Date: |
Mon, 12 Oct 2015 18:25:40 +0200 |
Processors up to the Pentium (says Bochs---I do not have old enough
manuals) require a 32KiB alignment for the SMBASE, but newer processors
do not need that, and Tiano Core will use non-aligned SMBASE values.
Reported-by: Michael D Kinney <address@hidden>
Cc: Laszlo Ersek <address@hidden>
Cc: Jordan Justen <address@hidden>
Cc: Eduardo Habkost <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
target-i386/smm_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-i386/smm_helper.c b/target-i386/smm_helper.c
index 02e24b9..c272a98 100644
--- a/target-i386/smm_helper.c
+++ b/target-i386/smm_helper.c
@@ -266,7 +266,7 @@ void helper_rsm(CPUX86State *env)
val = x86_ldl_phys(cs, sm_state + 0x7efc); /* revision ID */
if (val & 0x20000) {
- env->smbase = x86_ldl_phys(cs, sm_state + 0x7f00) & ~0x7fff;
+ env->smbase = x86_ldl_phys(cs, sm_state + 0x7f00);
}
#else
cpu_x86_update_cr0(env, x86_ldl_phys(cs, sm_state + 0x7ffc));
@@ -319,7 +319,7 @@ void helper_rsm(CPUX86State *env)
val = x86_ldl_phys(cs, sm_state + 0x7efc); /* revision ID */
if (val & 0x20000) {
- env->smbase = x86_ldl_phys(cs, sm_state + 0x7ef8) & ~0x7fff;
+ env->smbase = x86_ldl_phys(cs, sm_state + 0x7ef8);
}
#endif
if ((env->hflags2 & HF2_SMM_INSIDE_NMI_MASK) == 0) {
--
2.5.0
- [Qemu-devel] [PATCH] target-i386: allow any alignment for SMBASE,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH] target-i386: allow any alignment for SMBASE, Laszlo Ersek, 2015/10/15
- Re: [Qemu-devel] [PATCH] target-i386: allow any alignment for SMBASE, Eduardo Habkost, 2015/10/13
- Re: [Qemu-devel] [PATCH] target-i386: allow any alignment for SMBASE, Paolo Bonzini, 2015/10/13
- Re: [Qemu-devel] [PATCH] target-i386: allow any alignment for SMBASE, Eduardo Habkost, 2015/10/13
- Re: [Qemu-devel] [PATCH] target-i386: allow any alignment for SMBASE, Laszlo Ersek, 2015/10/23
- Re: [Qemu-devel] [PATCH] target-i386: allow any alignment for SMBASE, Eduardo Habkost, 2015/10/23
- Re: [Qemu-devel] [PATCH] target-i386: allow any alignment for SMBASE, Laszlo Ersek, 2015/10/23