[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 04/50] ivhsmem: read do not accept more than sizeo
From: |
marcandre . lureau |
Subject: |
[Qemu-devel] [PULL v2 04/50] ivhsmem: read do not accept more than sizeof(long) |
Date: |
Mon, 12 Oct 2015 18:40:58 +0200 |
From: Marc-André Lureau <address@hidden>
ivshmem_read() only reads sizeof(long) from the input buffer. Accepting
more could lead to fifo8 abort() on 32bit systems if fifo is not empty.
A following patch will change the protocol to 64-bit little-endian
instead.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Claudio Fontana <address@hidden>
---
hw/misc/ivshmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index cc76989..fb53b3f 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -272,7 +272,7 @@ static void ivshmem_receive(void *opaque, const uint8_t
*buf, int size)
static int ivshmem_can_receive(void * opaque)
{
- return 8;
+ return sizeof(long);
}
static void ivshmem_event(void *opaque, int event)
--
2.4.3
- [Qemu-devel] [PULL v2 00/50] Ivshmem patches, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 02/50] char: add qemu_chr_free(), marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 03/50] msix: add VMSTATE_MSIX_TEST, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 04/50] ivhsmem: read do not accept more than sizeof(long),
marcandre . lureau <=
- [Qemu-devel] [PULL v2 05/50] ivshmem: fix number of bytes to push to fifo, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 06/50] ivshmem: factor out the incoming fifo handling, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 08/50] ivshmem: remove superflous ivshmem_attr field, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 09/50] ivshmem: remove useless doorbell field, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 10/50] ivshmem: more qdev conversion, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 11/50] ivshmem: remove last exit(1), marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 12/50] ivshmem: limit maximum number of peers to G_MAXUINT16, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 13/50] ivshmem: simplify around increase_dynamic_storage(), marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 14/50] ivshmem: allocate eventfds in resize_peers(), marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 16/50] ivshmem: initialize max_peer to -1, marcandre . lureau, 2015/10/12