[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 00/50] Ivshmem patches
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL v2 00/50] Ivshmem patches |
Date: |
Tue, 13 Oct 2015 10:29:55 +0100 |
On 12 October 2015 at 17:40, <address@hidden> wrote:
> From: Marc-André Lureau <address@hidden>
>
> The following changes since commit 0bf224d5da41967a775b328234cda2d19f303908:
>
> Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into
> staging (2015-10-12 14:29:29 +0100)
>
> are available in the git repository at:
>
> address@hidden:elmarco/qemu.git tags/ivshmem-pull-request
>
> for you to fetch changes up to a3920e445af166ae95651a63bcd0d3b4694eed14:
>
> doc: document ivshmem & hugepages (2015-10-12 18:02:51 +0200)
>
> ----------------------------------------------------------------
> This new pull request includes Andreas qtest patch, a doc patch, and
> fixes some new glib API usage in tests.
> ----------------------------------------------------------------
Hi. I'm afraid this fails to build on OSX:
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-server/ivshmem-server.c:13:10:
fatal error: 'sys/even
tfd.h' file not found
#include <sys/eventfd.h>
^
CC contrib/ivshmem-server/main.o
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:111:48:
warning: format speci
fies type 'long' but the argument has type 'int64_t' (aka 'long long')
[-Wformat]
"peer %ld\n", peer_id);
~~~ ^~~~~~~
%lld
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21:28:
note: expanded from ma
cro 'IVSHMEM_CLIENT_DEBUG'
printf(fmt, ## __VA_ARGS__); \
^
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:115:64:
warning: format speci
fies type 'long' but the argument has type 'int64_t' (aka 'long long')
[-Wformat]
IVSHMEM_CLIENT_DEBUG(client, "delete peer id = %ld\n", peer_id);
~~~ ^~~~~~~
%lld
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21:28:
note: expanded from ma
cro 'IVSHMEM_CLIENT_DEBUG'
printf(fmt, ## __VA_ARGS__); \
^
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:126:61:
warning: format speci
fies type 'long' but the argument has type 'int64_t' (aka 'long long')
[-Wformat]
IVSHMEM_CLIENT_DEBUG(client, "new peer id = %ld\n", peer_id);
~~~ ^~~~~~~
%lld
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21:28:
note: expanded from ma
cro 'IVSHMEM_CLIENT_DEBUG'
printf(fmt, ## __VA_ARGS__); \
^
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:131:51:
warning: format speci
fies type 'long' but the argument has type 'int64_t' (aka 'long long')
[-Wformat]
peer->vectors_count, fd, peer->id);
^~~~~~~~
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21:28:
note: expanded from ma
cro 'IVSHMEM_CLIENT_DEBUG'
printf(fmt, ## __VA_ARGS__); \
^
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:223:50:
warning: format speci
fies type 'long' but the argument has type 'int64_t' (aka 'long long')
[-Wformat]
IVSHMEM_CLIENT_DEBUG(client, "our_id=%ld\n", client->local.id);
~~~ ^~~~~~~~~~~~~~~~
%lld
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21:28:
note: expanded from macro 'IVSHMEM_CLIENT_DEBUG'
printf(fmt, ## __VA_ARGS__); \
^
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:318:51:
warning: format specifies type 'long' but the argument has type
'uint64_t' (aka 'unsigned long long') [-Wformat]
peer->vectors[i], i, kick);
^~~~
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21:28:
note: expanded from macro 'IVSHMEM_CLIENT_DEBUG'
printf(fmt, ## __VA_ARGS__); \
^
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:355:30:
warning: format specifies type 'long' but the argument has type
'int64_t' (aka 'long long') [-Wformat]
peer->id);
^~~~~~~~
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21:28:
note: expanded from macro 'IVSHMEM_CLIENT_DEBUG'
printf(fmt, ## __VA_ARGS__); \
^
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:360:26:
warning: format specifies type 'long' but the argument has type
'int64_t' (aka 'long long') [-Wformat]
peer->id, vector, fd);
^~~~~~~~
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:21:28:
note: expanded from macro 'IVSHMEM_CLIENT_DEBUG'
printf(fmt, ## __VA_ARGS__); \
^
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:431:30:
warning: format specifies type 'long' but the argument has type
'int64_t' (aka 'long long') [-Wformat]
printf("our_id = %ld\n", peer->id);
~~~ ^~~~~~~~
%lld
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/ivshmem-client.c:439:35:
warning: format specifies type 'long' but the argument has type
'int64_t' (aka 'long long') [-Wformat]
printf("peer_id = %ld\n", peer->id);
~~~ ^~~~~~~~
%lld
1 error generated.
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-client/main.c:182:65:
warning: format specifies type 'long' but the argument has type
'int64_t' (aka 'long long') [-Wformat]
printf("receive notification from peer_id=%ld vector=%d\n", peer->id, vect);
~~~ ^~~~~~~~
%lld
make: *** [contrib/ivshmem-server/ivshmem-server.o] Error 1
make: *** Waiting for unfinished jobs....
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-server/main.c:107:51:
warning: incompatible pointer types passing 'size_t *' (aka 'unsigned
long *') to parameter of type 'uint64_t *' (aka 'unsigned long long
*') [-Wincompatible-pointer-types]
parse_option_size("shm_size", optarg, &args->shm_size, &errp);
^~~~~~~~~~~~~~~
/Users/pm215/src/qemu-for-merges/include/qemu/option.h:44:34: note:
passing argument to parameter 'ret' here
uint64_t *ret, Error **errp);
^
/Users/pm215/src/qemu-for-merges/contrib/ivshmem-server/main.c:239:13:
warning: 'daemon' is deprecated: first deprecated in OS X 10.5
[-Wdeprecated-declarations]
if (daemon(1, 1) < 0) {
^
/usr/include/stdlib.h:267:6: note: 'daemon' has been explicitly marked
deprecated here
int daemon(int, int) __DARWIN_1050(daemon)
__OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_0, __MAC_10_5, __IPHONE_2_0,
__IPHONE_2_0);
^
The various format string warnings also cause build failures on
32-bit Linux.
thanks
-- PMM
- [Qemu-devel] [PULL v2 38/50] contrib: remove unnecessary strdup(), (continued)
- [Qemu-devel] [PULL v2 38/50] contrib: remove unnecessary strdup(), marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 40/50] qtest: add qtest_add_abrt_handler(), marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 41/50] glib-compat: add 2.38/2.40/2.46 asserts, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 42/50] tests: add ivshmem qtest, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 44/50] ivshmem: use qemu_strtosz(), marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 47/50] ivshmem: rename MSI eventfd_table, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 48/50] ivshmem: use kvm irqfd for msi notifications, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 49/50] ivshmem: use little-endian int64_t for the protocol, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 50/50] doc: document ivshmem & hugepages, marcandre . lureau, 2015/10/12
- [Qemu-devel] [PULL v2 39/50] msix: implement pba write (but read-only), marcandre . lureau, 2015/10/12
- Re: [Qemu-devel] [PULL v2 00/50] Ivshmem patches,
Peter Maydell <=
- [Qemu-devel] [PULL v2 01/50] tests: Add ivshmem qtest, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 15/50] ivshmem: remove useless ivshmem_update_irq() val argument, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 07/50] ivshmem: remove unnecessary dup(), marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 24/50] ivshmem: migrate with VMStateDescription, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 25/50] ivshmem: shmfd can be 0, marcandre . lureau, 2015/10/15
- [Qemu-devel] [PULL v2 19/50] ivshmem: improve error handling, marcandre . lureau, 2015/10/15