Re: [Qemu-devel] [PATCH v3 04/32] acpi: add aml_mutex, aml_acquire, aml_release

[Xiao Guangrong]

On 10/13/2015 09:34 PM, Igor Mammedov wrote:
> On Sun, 11 Oct 2015 11:52:36 +0800
> Xiao Guangrong <address@hidden> wrote:
>
> > Implement Mutex, Acquire and Release terms which are used by NVDIMM _DSM method
> > in later patch
> >
> > Signed-off-by: Xiao Guangrong <address@hidden>
> > ---
> >   hw/acpi/aml-build.c         | 32 ++++++++++++++++++++++++++++++++
> >   include/hw/acpi/aml-build.h |  3 +++
> >   2 files changed, 35 insertions(+)
> >
> > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
> > index 9fe5e7b..ab52692 100644
> > --- a/hw/acpi/aml-build.c
> > +++ b/hw/acpi/aml-build.c
> > @@ -1164,6 +1164,38 @@ Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, 
> > const char *name)
> >       return var;
> >   }
> >
> > +/* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefMutex */
> > +Aml *aml_mutex(const char *name, uint8_t flags)
> s/flags/sync_level/

Oops, will fix.

> > +{
> > +    Aml *var = aml_alloc();
> > +    build_append_byte(var->buf, 0x5B); /* ExtOpPrefix */
> > +    build_append_byte(var->buf, 0x01); /* MutexOp */
> > +    build_append_namestring(var->buf, "%s", name);
>
> add assert here to check that reserved bits are 0

Good idea, will do.