[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ui/cocoa.m: eliminate normalWindow warning
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] ui/cocoa.m: eliminate normalWindow warning |
Date: |
Tue, 13 Oct 2015 21:33:29 +0100 |
On 25 September 2015 at 23:34, Programmingkid <address@hidden> wrote:
> Eliminate this warning associated with the setting of the normalWindow's
> title:
>
> ui/cocoa.m: In function '-[QemuCocoaAppController init]':
> ui/cocoa.m:888:9: warning: format not a string literal and no format arguments
> [-Wformat-security]
> [normalWindow setTitle:[NSString stringWithFormat:@"QEMU"]];
>
>
> Signed-off-by: John Arbuckle <address@hidden>
>
> ---
> ui/cocoa.m | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index 334e6f6..fa21fdb 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -855,7 +855,7 @@ QemuCocoaView *cocoaView;
> exit(1);
> }
> [normalWindow setAcceptsMouseMovedEvents:YES];
> - [normalWindow setTitle:[NSString stringWithFormat:@"QEMU"]];
> + [normalWindow setTitle:@"QEMU"];
> [normalWindow setContentView:cocoaView];
> #if (MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_10)
> [normalWindow useOptimizedDrawing:YES];
> --
> 1.7.5.4
Thanks, applied to cocoa.next (sorry it's taken me a while
to get back to these).
-- PMM
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] ui/cocoa.m: eliminate normalWindow warning,
Peter Maydell <=