[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -
From: |
OGAWA Hirofumi |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode |
Date: |
Thu, 15 Oct 2015 17:50:12 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
OGAWA Hirofumi <address@hidden> writes:
>> Ok, curses and gtk can't be active at the same time. But for curses and
>> vnc it is possible (qemu -curses -vnc :$display), and you probably get a
>> dissorted vga text mode over vnc then.
>>
>> I think the mapping should happen in the curses code, when curses
>> updates the screen. curses_update() function is probably the best place
>> for it.
>
> OK. It would be possible though, but parsing at curses_update() is
> slower. It is why, I did at that. Well, I'll see.
I've checked callers and usage of console_write_ch(). Call path is
following paths.
curses_refresh()
graphic_hw_text_update(NULL, screen);
->text_update()
vga_update_text()
console_write_ch()
->text_update()
jazz_led_text_update()
console_write_ch()
->text_update()
text_console_update()
console_write_ch()
>From this call paths, graphic_hw_text_update() => console_write_ch() =>
->text_update() path is only used for -curses mode. What do you think?
(E.g. qemu is going to extend to use this for other purpose?)
I guess, rather qemu wants to remove the call of ->text_update() for
micro optimization if curses display is not used. (I'm not sure how
optimizes it right now though.)
Thanks.
--
OGAWA Hirofumi <address@hidden>
- [Qemu-devel] [PATCH 1/3] ui/curses: Fix monitor color with -curses when 256 colors, (continued)
- [Qemu-devel] [PATCH 1/3] ui/curses: Fix monitor color with -curses when 256 colors, OGAWA Hirofumi, 2015/10/15
- [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/14
- [Qemu-devel] [PATCH 3/3] ui/curses: Fix pageup/pagedown on -curses, OGAWA Hirofumi, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Eric Blake, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/14
- [Qemu-devel] [PATCH v2 1/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/14
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode,
OGAWA Hirofumi <=
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- [Qemu-devel] [PATCH v3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/19
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/19
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/10/15
- Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
- [Qemu-devel] [PATCH v4] ui/curses: Support line graphics chars on -curses mode, OGAWA Hirofumi, 2015/10/15
Re: [Qemu-devel] [RFC 0/3] improve/fix -curses mode, Markus Armbruster, 2015/10/15