qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -


From: OGAWA Hirofumi
Subject: Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode
Date: Thu, 15 Oct 2015 18:58:17 +0900
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

Gerd Hoffmann <address@hidden> writes:

>> > Also you don't need a init function, you can simply init the array with
>> > c99 initializers:
>> >
>> > chtype vga_to_curses[256] = {
>> >     [0x04] = ACS_DIAMOND,
>> >     [ ... ]
>> > };
>> 
>> This is not possible, because ACS_* is not constant (initialized by
>> reading from termcap or such).
>
> Ah, ok.  That isn't obvious from reading the code.  Can you add a
> comment please?

Oh, sent updated patch already. I will resend a updated patch to this
reply.
-- 
OGAWA Hirofumi <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]