[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 3/3] kvm: Pass PCI device pointer to MSI rout
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v5 3/3] kvm: Pass PCI device pointer to MSI routing functions |
Date: |
Thu, 15 Oct 2015 13:41:15 +0200 |
On Thu, 15 Oct 2015 14:05:17 +0300
Pavel Fedin <address@hidden> wrote:
> In-kernel ITS emulation on ARM64 will require to supply requester IDs.
> These IDs can now be retrieved from the device pointer using new
> pci_requester_id() function.
>
> This patch adds pci_dev pointer to KVM GSI routing functions and makes
> callers passing it.
Should the pci_dev be passed to kvm_arch_fixup_msi_route() as well?
Currently, the only implementer of this function (s390x) does not need
it; but it shouldn't hurt?
>
> x86 architecture does not use requester IDs, but hw/i386/kvm/pci-assign.c
> also made passing PCI device pointer instead of NULL for consistency with
> the rest of the code.
>
> Signed-off-by: Pavel Fedin <address@hidden>
> ---
> hw/i386/kvm/pci-assign.c | 9 +++++----
> hw/vfio/pci.c | 11 ++++++-----
> hw/virtio/virtio-pci.c | 5 +++--
> include/sysemu/kvm.h | 5 +++--
> kvm-all.c | 5 +++--
> kvm-stub.c | 5 +++--
> 6 files changed, 23 insertions(+), 17 deletions(-)