qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] ui/cocoa.m: addRemovableDevicesMenuItems() warn


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] ui/cocoa.m: addRemovableDevicesMenuItems() warning fix
Date: Tue, 13 Oct 2015 21:33:55 +0100

On 25 September 2015 at 23:44, Programmingkid <address@hidden> wrote:
> Eliminate this warning associated with the addRemovableDevicesMenuItems()
> function:
>
> ui/cocoa.m:1344:13: warning: function declaration isn't a prototype
> [-Wstrict-prototypes]
>  static void addRemovableDevicesMenuItems()
>              ^
> ui/cocoa.m: In function 'addRemovableDevicesMenuItems':
> ui/cocoa.m:1344:13: warning: old-style function definition 
> [-Wold-style-definition]
>
>
> Signed-off-by: John Arbuckle <address@hidden>
>
> ---
>  ui/cocoa.m |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index 334e6f6..a94cc68 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -1341,7 +1341,7 @@ static void add_console_menu_entries(void)
>  /* Make menu items for all removable devices.
>   * Each device is given an 'Eject' and 'Change' menu item.
>   */
> -static void addRemovableDevicesMenuItems()
> +static void addRemovableDevicesMenuItems(void)
>  {
>      NSMenu *menu;
>      NSMenuItem *menuItem;
> --
> 1.7.5.4
>

Thanks, applied to cocoa.next.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]