[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] arm_gic_kvm: Disable live migration if not supp
|
From: |
Pavel Fedin |
|
Subject: |
Re: [Qemu-devel] [PATCH] arm_gic_kvm: Disable live migration if not supported |
|
Date: |
Fri, 16 Oct 2015 10:52:10 +0300 |
Hello!
> But this is the GICv2 code. Unless there are kernels out in the wild
> which support v2 but not migration, there's no need to check
> for that situation here.
Such kernels do exist for sure, otherwise why do we have
kvm_gic_can_save_restore() at all? I remember even you pointed me at it.
I've just checked LXR, we have vGIC support since 3.11, but
KVM_DEV_TYPE_ARM_VGIC_V2 was introduced only in 3.14.
P.S. While studying migration code i discovered migrate_add_blocker(), i guess
i need to use it instead of patching VMState, because checkpatch blames me for
making it non-const. So, if you ACK the idea itself, i'll reimplement it and
post v2.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia