[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 4/9] target-i386: Move hw_*breakpoint_* functions
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH v2 4/9] target-i386: Move hw_*breakpoint_* functions |
Date: |
Fri, 16 Oct 2015 13:23:34 -0300 |
From: Richard Henderson <address@hidden>
They're only used from bpt_helper.c now.
Signed-off-by: Richard Henderson <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
target-i386/bpt_helper.c | 29 ++++++++++++++++++++++++++++-
target-i386/cpu.h | 27 ---------------------------
2 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/target-i386/bpt_helper.c b/target-i386/bpt_helper.c
index 493deba..afa28df 100644
--- a/target-i386/bpt_helper.c
+++ b/target-i386/bpt_helper.c
@@ -22,6 +22,33 @@
#ifndef CONFIG_USER_ONLY
+static inline bool hw_local_breakpoint_enabled(unsigned long dr7, int index)
+{
+ return (dr7 >> (index * 2)) & 1;
+}
+
+static inline bool hw_global_breakpoint_enabled(unsigned long dr7, int index)
+{
+ return (dr7 >> (index * 2)) & 2;
+
+}
+static inline bool hw_breakpoint_enabled(unsigned long dr7, int index)
+{
+ return hw_global_breakpoint_enabled(dr7, index) ||
+ hw_local_breakpoint_enabled(dr7, index);
+}
+
+static inline int hw_breakpoint_type(unsigned long dr7, int index)
+{
+ return (dr7 >> (DR7_TYPE_SHIFT + (index * 4))) & 3;
+}
+
+static inline int hw_breakpoint_len(unsigned long dr7, int index)
+{
+ int len = ((dr7 >> (DR7_LEN_SHIFT + (index * 4))) & 3);
+ return (len == 2) ? 8 : len + 1;
+}
+
static void hw_breakpoint_insert(CPUX86State *env, int index)
{
CPUState *cs = CPU(x86_env_get_cpu(env));
@@ -116,7 +143,6 @@ void cpu_x86_update_dr7(CPUX86State *env, uint32_t new_dr7)
env->dr[7] |= DR7_FIXED_1;
}
-#endif
static bool check_hw_breakpoints(CPUX86State *env, bool force_dr6_update)
{
@@ -187,6 +213,7 @@ void breakpoint_handler(CPUState *cs)
}
}
}
+#endif
void helper_single_step(CPUX86State *env)
{
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index c818801..c9e4edf 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -1127,33 +1127,6 @@ void x86_stl_phys(CPUState *cs, hwaddr addr, uint32_t
val);
void x86_stq_phys(CPUState *cs, hwaddr addr, uint64_t val);
#endif
-static inline bool hw_local_breakpoint_enabled(unsigned long dr7, int index)
-{
- return (dr7 >> (index * 2)) & 1;
-}
-
-static inline bool hw_global_breakpoint_enabled(unsigned long dr7, int index)
-{
- return (dr7 >> (index * 2)) & 2;
-
-}
-static inline bool hw_breakpoint_enabled(unsigned long dr7, int index)
-{
- return hw_global_breakpoint_enabled(dr7, index) ||
- hw_local_breakpoint_enabled(dr7, index);
-}
-
-static inline int hw_breakpoint_type(unsigned long dr7, int index)
-{
- return (dr7 >> (DR7_TYPE_SHIFT + (index * 4))) & 3;
-}
-
-static inline int hw_breakpoint_len(unsigned long dr7, int index)
-{
- int len = ((dr7 >> (DR7_LEN_SHIFT + (index * 4))) & 3);
- return (len == 2) ? 8 : len + 1;
-}
-
void breakpoint_handler(CPUState *cs);
/* will be suppressed */
--
2.1.0
- [Qemu-devel] [PATCH v2 0/9] target-i386: Implement debug extensions, Eduardo Habkost, 2015/10/16
- [Qemu-devel] [PATCH v2 1/9] target-i386: Introduce cpu_x86_update_dr7, Eduardo Habkost, 2015/10/16
- [Qemu-devel] [PATCH v2 2/9] target-i386: Re-introduce optimal breakpoint removal, Eduardo Habkost, 2015/10/16
- [Qemu-devel] [PATCH v2 3/9] target-i386: Ensure bit 10 on DR7 is never cleared, Eduardo Habkost, 2015/10/16
- [Qemu-devel] [PATCH v2 4/9] target-i386: Move hw_*breakpoint_* functions,
Eduardo Habkost <=
- [Qemu-devel] [PATCH v2 5/9] target-i386: Optimize setting dr[0-3], Eduardo Habkost, 2015/10/16
- [Qemu-devel] [PATCH v2 6/9] target-i386: Handle I/O breakpoints, Eduardo Habkost, 2015/10/16
[Qemu-devel] [PATCH v2 7/9] target-i386: Check CR4[DE] for processing DR4/DR5, Eduardo Habkost, 2015/10/16
[Qemu-devel] [PATCH v2 8/9] target-i386: Ensure always-1 bits on DR6 can't be cleared, Eduardo Habkost, 2015/10/16
[Qemu-devel] [PATCH v2 9/9] target-i386: Add DE to TCG_FEATURES, Eduardo Habkost, 2015/10/16