qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] kvm: Allow the Hyper-V vendor ID to be speci


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2] kvm: Allow the Hyper-V vendor ID to be specified
Date: Mon, 19 Oct 2015 10:08:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0


On 16/10/2015 17:38, Alex Williamson wrote:
> According to Microsoft documentation, the signature in the standard
> hypervisor CPUID leaf at 0x40000000 identifies the Vendor ID and is
> for reporting and diagnostic purposes only.  We can therefore allow
> the user to change it to whatever they want, within the 12 character
> limit.  Add a new hyperv-vendor-id option to the -cpu flag to allow
> for this, ex:
> 
>  -cpu host,hv_time,hv_vendor_id=KeenlyKVM
> 
> Link: http://msdn.microsoft.com/library/windows/hardware/hh975392
> Signed-off-by: Alex Williamson <address@hidden>
> ---
> 
> v2: Replace abort() with truncating the string, error report updated
> 
> Igor also had the idea of creating a DEFINE_PROP_STRING_LEN property
> where we could enforce the length earlier in the parameter checking.
> If we like that idea, we probably need to do it first since we don't
> want to switch from truncating to erroring between releases.  I can
> work on that if preferred.  Thanks,

I applied this one, because the truncation matches what is done in other
places (ACPI tables, SCSI product/vendor, etc.)

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]