Re: [Qemu-devel] [PULL 2/2] xen-platform: Ensure xen is enabled when initializing

[Eduardo Habkost]

On Mon, Oct 19, 2015 at 12:48:11PM +0200, Paolo Bonzini wrote:
> 
> 
> On 19/10/2015 12:23, Stefano Stabellini wrote:
> > The xen-platform code crashes on reset if the xen backend is not
> > initialized, because it calls xc_hvm_set_mem_type(). Ensure xen-platform
> > won't be created without initializing the xen backend.
> > 
> > The assert can't be triggered by the user because the device is not
> > hotpluggable, and the only code creating it (at pc_xen_hvm_init())
> > already checks xen_enabled().
> 
> The device is not hotpluggable, but it is accessible with -device.  This
> is by design because IIUC, we want -M xenfv to be phased out in favor of
> the PC machines plus -device xen-platform.

Oops, that means the assert() needs to be replaced with proper error
reporting. I will do it.

> 
> Thus, k->init should be changed to k->realize instead.  I guess it can
> be done on top of this pull request, so I'm not blocking it.

xen_platform_initfn() is PCIDeviceClass::init, which is called from
realize.

-- 
Eduardo