[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 27/39] block: Add blk_remove_bs()
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v7 27/39] block: Add blk_remove_bs() |
Date: |
Tue, 20 Oct 2015 10:33:51 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 19.10.2015 um 17:53 hat Max Reitz geschrieben:
> This function removes the BlockDriverState associated with the given
> BlockBackend from that BB and sets the BDS pointer in the BB to NULL.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/block-backend.c | 12 ++++++++++++
> include/sysemu/block-backend.h | 1 +
> 2 files changed, 13 insertions(+)
>
> diff --git a/block/block-backend.c b/block/block-backend.c
> index 19fdaae..eb7409c 100644
> --- a/block/block-backend.c
> +++ b/block/block-backend.c
> @@ -334,6 +334,18 @@ void blk_hide_on_behalf_of_hmp_drive_del(BlockBackend
> *blk)
> }
>
> /*
> + * Disassociates the currently associated BlockDriverState from @blk.
> + */
> +void blk_remove_bs(BlockBackend *blk)
> +{
> + blk_update_root_state(blk);
> +
> + bdrv_unref(blk->bs);
> + blk->bs->blk = NULL;
Use after free?
> + blk->bs = NULL;
> +}
Kevin
- [Qemu-devel] [PATCH v7 20/39] block: Fail requests to empty BlockBackend, (continued)
- [Qemu-devel] [PATCH v7 20/39] block: Fail requests to empty BlockBackend, Max Reitz, 2015/10/19
- [Qemu-devel] [PATCH v7 24/39] blockdev: Do not create BDS for empty drive, Max Reitz, 2015/10/19
- [Qemu-devel] [PATCH v7 23/39] block: Prepare for NULL BDS, Max Reitz, 2015/10/19
- [Qemu-devel] [PATCH v7 25/39] blockdev: Pull out blockdev option extraction, Max Reitz, 2015/10/19
- [Qemu-devel] [PATCH v7 28/39] blockdev: Add blockdev-open-tray, Max Reitz, 2015/10/19
- [Qemu-devel] [PATCH v7 27/39] block: Add blk_remove_bs(), Max Reitz, 2015/10/19
- Re: [Qemu-devel] [PATCH v7 27/39] block: Add blk_remove_bs(),
Kevin Wolf <=
- [Qemu-devel] [PATCH v7 26/39] blockdev: Allow more options for BB-less BDS tree, Max Reitz, 2015/10/19
- [Qemu-devel] [PATCH v7 30/39] blockdev: Add blockdev-remove-medium, Max Reitz, 2015/10/19
- [Qemu-devel] [PATCH v7 31/39] blockdev: Add blockdev-insert-medium, Max Reitz, 2015/10/19
- Re: [Qemu-devel] [PATCH v7 31/39] blockdev: Add blockdev-insert-medium, Kevin Wolf, 2015/10/23