[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/5] Revert "vhost-user: Send VHOST_RESET_OWN
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/5] Revert "vhost-user: Send VHOST_RESET_OWNER on vhost stop" |
Date: |
Wed, 21 Oct 2015 13:39:53 +0300 |
On Wed, Oct 21, 2015 at 05:07:17PM +0800, Yuanhan Liu wrote:
> Don't send VHOST_RESET_OWNER, for as Michael stated:
>
> Because we need to get the state from remote after stop.
> RESET_OWNER discards that, so we can't resume the VM.
>
> This reverts commit 294ce717e0f212ed0763307f3eab72b4a1bdf4d0.
>
> Cc: Luke Gorrie <address@hidden>
> Cc: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Yuanhan Liu <address@hidden>
Yes but poking at guest memory after driver is unloaded
is even worse.
> ---
> hw/net/vhost_net.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index 804f5c9..95da5f8 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -293,13 +293,6 @@ static void vhost_net_stop_one(struct vhost_net *net,
> &file);
> assert(r >= 0);
> }
> - } else if (net->nc->info->type == NET_CLIENT_OPTIONS_KIND_VHOST_USER) {
> - for (file.index = 0; file.index < net->dev.nvqs; ++file.index) {
> - const VhostOps *vhost_ops = net->dev.vhost_ops;
> - int r = vhost_ops->vhost_call(&net->dev, VHOST_RESET_OWNER,
> - NULL);
> - assert(r >= 0);
> - }
> }
> if (net->nc->info->poll) {
> net->nc->info->poll(net->nc, true);
> --
> 1.9.0
>
- [Qemu-devel] [PATCH v2 3/5] vhost-user-test: add multiple queue test, (continued)
[Qemu-devel] [PATCH v2 4/5] Revert "vhost-user: Send VHOST_RESET_OWNER on vhost stop", Yuanhan Liu, 2015/10/21
Re: [Qemu-devel] [PATCH v2 1/5] Revert "vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE", Michael S. Tsirkin, 2015/10/21