|
From: | Peter Maydell |
Subject: | Re: [Qemu-devel] What's the intended use of log.h logging? (was: [PATCH 2/3] log: report hmp/qmp command and qmp event) |
Date: | Wed, 21 Oct 2015 13:22:22 +0100 |
On 21 October 2015 at 11:41, Stefan Hajnoczi <address@hidden> wrote: > DPRINTF() falls under both #1 and #2. Care needs to be taken to > separate the logging from the tracing when converting DPRINTF(). > > Side note: we don't have effect "once only" or rate-limiting built into > error_report(). Guest-triggerable errors or warnings should be limited > to prevent log flooding. > > It would be nice to unify TCG's "qemu log" and error_report() into a > single logging mechanism that is thread-safe and has rate-limiting. As long as you can disable the rate-limiting: for almost all of the use cases for the qemu-log code you really don't want to have it drop logging messages. thanks -- PMM
[Prev in Thread] | Current Thread | [Next in Thread] |