qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 03/14] qapi: Provide nicer array names in int


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v7 03/14] qapi: Provide nicer array names in introspection
Date: Thu, 22 Oct 2015 18:12:44 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> For the sake of humans reading introspection output, it is nice
> to have the name of implicit array types be recognizable as
> arrays of the underlying type.  However, while this patch allows
> humans to skip from a command with return type "[123]" straight
> to the definition of type "123" without having to first inspect
> type "[123]", document that this shortcut should not be taken by
> client apps.

Personally, I still don't see much value in special-casing array names.
On the other hand, the patch is really simple.

> This makes the resulting introspection string slightly larger by
> default, but slightly smaller when -u is in use (as '[FOO]' is
> nicer than 'FOOList' for expressing 'array of FOO').

Size with -u is unimportant.

If we don't want to pay the prize in size without -u, we can make it
conditional on -u.  But with -u, [FOO] isn't much of an improvement over
FooList.

Anyway, if you want the feature, I'll take the patch.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]