[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 01/25] tests/qapi-schema: Test for reserved
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v10 01/25] tests/qapi-schema: Test for reserved names, empty struct |
Date: |
Fri, 23 Oct 2015 16:17:12 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 10/23/2015 06:33 AM, Markus Armbruster wrote:
>> Eric Blake <address@hidden> writes:
[...]
>>> +++ b/tests/qapi-schema/struct-name-list.json
>>> @@ -0,0 +1,5 @@
>>> +# Potential C name collision
>>> +# FIXME - This parses and compiles on its own, but prevents the user from
>>> +# creating a type named 'Foo' and using ['Foo'] for an array. We should
>>> +# reject the use of any non-array type names ending in 'List'.
>>> +{ 'struct': 'FooList', 'data': { 's': 'str' } }
>>
>> "Non-array type name" makes no sense when talking about the QAPI schema,
>> because arrays don't have names there.
>
> Suggestions? Maybe s/non-array//? The wording changes in 2/25 when the
> test starts working.
Dropping non-array works for me.
- [Qemu-devel] [PATCH v10 02/25] qapi: More idiomatic string operations, (continued)
- [Qemu-devel] [PATCH v10 02/25] qapi: More idiomatic string operations, Eric Blake, 2015/10/23
- [Qemu-devel] [PATCH v10 03/25] qapi: More robust conditions for when labels are needed, Eric Blake, 2015/10/23
- [Qemu-devel] [PATCH v10 06/25] vnc: Hoist allocation of VncBasicInfo to callers, Eric Blake, 2015/10/23
- [Qemu-devel] [PATCH v10 08/25] qapi-types: Refactor base fields output, Eric Blake, 2015/10/23
- [Qemu-devel] [PATCH v10 01/25] tests/qapi-schema: Test for reserved names, empty struct, Eric Blake, 2015/10/23
- [Qemu-devel] [PATCH v10 04/25] qapi: Reserve '*List' type names for list types, Eric Blake, 2015/10/23
- [Qemu-devel] [PATCH v10 13/25] qapi-visit: Convert to new qapi union layout, Eric Blake, 2015/10/23
[Qemu-devel] [PATCH v10 07/25] qapi-visit: Split off visit_type_FOO_fields forward decl, Eric Blake, 2015/10/23