Re: [Qemu-devel] [PATCH 15/19] pc: acpi: bump DSDT revision compliance to v2

[Michael S. Tsirkin]

On Fri, Oct 23, 2015 at 04:57:18PM +0200, Igor Mammedov wrote:
> it turns on 64-bit integer handling in OSPM, which we could use
> for writing simpler/smaller AML code.
> Tested with Windows XP and Windows Server 2008, Linux:
>  * XP doesn't care about revision and continues to use 32 integers
>    and boots just fine with this change.
>  * WS 2008 and Linux - support rev2 and use 64-bit integers
> 
> Signed-off-by: Igor Mammedov <address@hidden>

This is still planned, right? IIUC you didn't post any code
that needs the 64 bit math.

> ---
>  hw/i386/acpi-build.c      | 2 +-
>  hw/i386/acpi-dsdt.dsl     | 2 +-
>  hw/i386/q35-acpi-dsdt.dsl | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 8add4d9..c929540 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1484,7 +1484,7 @@ build_dsdt(GArray *table_data, GArray *linker, 
> AcpiMiscInfo *misc)
>  
>      memset(dsdt, 0, sizeof *dsdt);
>      build_header(linker, table_data, dsdt, "DSDT",
> -                 misc->dsdt_size, 1);
> +                 misc->dsdt_size, 2);
>  }
>  
>  static GArray *
> diff --git a/hw/i386/acpi-dsdt.dsl b/hw/i386/acpi-dsdt.dsl
> index 8dba096..6d46b36 100644
> --- a/hw/i386/acpi-dsdt.dsl
> +++ b/hw/i386/acpi-dsdt.dsl
> @@ -22,7 +22,7 @@ ACPI_EXTRACT_ALL_CODE AcpiDsdtAmlCode
>  DefinitionBlock (
>      "acpi-dsdt.aml",    // Output Filename
>      "DSDT",             // Signature
> -    0x01,               // DSDT Compliance Revision
> +    0x02,               // DSDT Compliance Revision
>      "BXPC",             // OEMID
>      "BXDSDT",           // TABLE ID
>      0x1                 // OEM Revision
> diff --git a/hw/i386/q35-acpi-dsdt.dsl b/hw/i386/q35-acpi-dsdt.dsl
> index 7be7b37..ecefdec 100644
> --- a/hw/i386/q35-acpi-dsdt.dsl
> +++ b/hw/i386/q35-acpi-dsdt.dsl
> @@ -28,7 +28,7 @@ ACPI_EXTRACT_ALL_CODE Q35AcpiDsdtAmlCode
>  DefinitionBlock (
>      "q35-acpi-dsdt.aml",// Output Filename
>      "DSDT",             // Signature
> -    0x01,               // DSDT Compliance Revision
> +    0x02,               // DSDT Compliance Revision
>      "BXPC",             // OEMID
>      "BXDSDT",           // TABLE ID
>      0x2                 // OEM Revision
> -- 
> 1.8.3.1