[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/9] trace: split trace_init_file out of trace_i
From: |
Christian Borntraeger |
Subject: |
Re: [Qemu-devel] [PATCH 3/9] trace: split trace_init_file out of trace_init_backends |
Date: |
Mon, 26 Oct 2015 10:03:20 +0900 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
Am 25.10.2015 um 22:32 schrieb Paolo Bonzini:
> diff --git a/trace/control.h b/trace/control.h
> index bfbe560..d2506d4 100644
> --- a/trace/control.h
> +++ b/trace/control.h
> @@ -157,7 +157,7 @@ static void trace_event_set_state_dynamic(TraceEvent *ev,
> bool state);
> *
> * Returns: Whether the backends could be successfully initialized.
> */
> -bool trace_init_backends(const char *file);
> +bool trace_init_backends(void);
>
> /**
> * trace_init_events:
This (and the patch before) break qemu-io:
/home/cborntra/REPOS/qemu/qemu-io.c: In function 'main':
/home/cborntra/REPOS/qemu/qemu-io.c:443:18: error: too many arguments to
function 'trace_init_backends'
if (!trace_init_backends(optarg, NULL)) {
^
In file included from /home/cborntra/REPOS/qemu/qemu-io.c:26:0:
/home/cborntra/REPOS/qemu/trace/control.h:160:6: note: declared here
bool trace_init_backends(void);
^
/home/cborntra/REPOS/qemu/rules.mak:57: recipe for target 'qemu-io.o' failed
Christian
- [Qemu-devel] [PATCH 0/9] simplify usage of tracepoints, and connect them to logging, Paolo Bonzini, 2015/10/25
- [Qemu-devel] [PATCH 1/9] trace: fix documentation, Paolo Bonzini, 2015/10/25
- [Qemu-devel] [PATCH 2/9] trace: split trace_init_events out of trace_init_backends, Paolo Bonzini, 2015/10/25
- [Qemu-devel] [PATCH 3/9] trace: split trace_init_file out of trace_init_backends, Paolo Bonzini, 2015/10/25
- Re: [Qemu-devel] [PATCH 3/9] trace: split trace_init_file out of trace_init_backends,
Christian Borntraeger <=
- [Qemu-devel] [PATCH 5/9] trace: add "-trace help", Paolo Bonzini, 2015/10/25
- [Qemu-devel] [PATCH 4/9] trace: add "-trace enable=...", Paolo Bonzini, 2015/10/25
- [Qemu-devel] [PATCH 6/9] log: do not unnecessarily include qom/cpu.h, Paolo Bonzini, 2015/10/25
- [Qemu-devel] [PATCH 7/9] trace: convert stderr backend to log, Paolo Bonzini, 2015/10/25
- [Qemu-devel] [PATCH 8/9] trace: switch default backend to "log", Paolo Bonzini, 2015/10/25
- [Qemu-devel] [PATCH 9/9] log: add "-d trace:PATTERN", Paolo Bonzini, 2015/10/25
- Re: [Qemu-devel] [PATCH 0/9] simplify usage of tracepoints, and connect them to logging, Peter Maydell, 2015/10/25
- Re: [Qemu-devel] [PATCH 0/9] simplify usage of tracepoints, and connect them to logging, Christian Borntraeger, 2015/10/25
- Re: [Qemu-devel] [PATCH 0/9] simplify usage of tracepoints, and connect them to logging, Christian Borntraeger, 2015/10/25