qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv2] tests: re-enable vhost-user-test


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCHv2] tests: re-enable vhost-user-test
Date: Mon, 26 Oct 2015 17:30:51 +0000

On 26 October 2015 at 14:32,  <address@hidden> wrote:
> From: Marc-André Lureau <address@hidden>
>
> Commit 7fe34ca9c2e actually disabled vhost-user-test altogether,
> since CONFIG_VHOST_NET is a per-target config variable.
>
> tests/vhost-user-test is already x86/x64 softmmu specific test, in order
> to enable it correctly, kvm & vhost-net are also conditions. To check
> that, set CONFIG_VHOST_NET_TEST_$target when kvm is also enabled.
>
> Since "check-qtest-x86_64-y = $(check-qtest-i386-y)", avoid duplication
> when both x86 & x64 are enabled.
>
> Other targets than x86 aren't enabled yet, and is intentionally left as
> a future improvement, since I can't easily test those.
>
> Signed-off-by: Marc-André Lureau <address@hidden>

I ran this through my build-tests, which pass, but:

(a) there's still the clang warning about the negative shifts
in target-i386/. This is an ancient bug and we can fix it later.

(b) there are new warning messages:
Warning: path not on HugeTLBFS: /tmp/vhost-test-xaGJRK
Warning: path not on HugeTLBFS: /tmp/vhost-test-xaGJRK
Warning: path not on HugeTLBFS: /tmp/vhost-test-xaGJRK

I would like (b) fixed -- tests should either:
 (1) complete without printing "warning" about anything
 (2) fail the test if the warning is actually important
 (3) skip the test if the test requires something that the host
     machine doesn't have (like a hugetlbfs)

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]