[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] qemu-io: Correct error messages
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] qemu-io: Correct error messages |
Date: |
Tue, 27 Oct 2015 10:07:40 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/27/2015 09:50 AM, John Snow wrote:
>>> + default:
>>> + printf("Parsing error -- %s\n", arg);
>>
>> I still think ':' is better than ' --' in error messages, but I'll leave
>> it up to the maintainer.
>>
>
> Crud, sorry Eric -- I didn't do this on purpose. As Kevin notes, I was
> just trying to match the existing format. I can change it and send again
> if you want. Whatever is easiest for people.
And Kevin has a valid point that you just did code motion, so keeping --
is no worse than before. At this point, I'll leave it up to you; my R-b
stands either way.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature