qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 07/17] qcow2: add a 'keyid' parameter to qcow2 o


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 07/17] qcow2: add a 'keyid' parameter to qcow2 options
Date: Wed, 28 Oct 2015 07:58:49 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0

On 10/19/2015 05:29 PM, Eric Blake wrote:
> On 10/19/2015 09:09 AM, Daniel P. Berrange wrote:
>> Add a 'keyid' parameter that refers to the ID of a
>> QCryptoSecret instance that provides the encryption key.
>>
>> $QEMU \
>>     -object secret,id=sec0,filename=/home/berrange/encrypted.pw \
>>     -drive file=/home/berrange/encrypted.qcow2,keyid=sec0
>>
>> Signed-off-by: Daniel P. Berrange <address@hidden>
>> ---
>>  block/qcow2.c        | 80 
>> +++++++++++++++++++++++++++++++++++++---------------
>>  block/qcow2.h        |  1 +
>>  qapi/block-core.json |  8 ++++--
>>  3 files changed, 64 insertions(+), 25 deletions(-)
>>
> 
>> +++ b/qapi/block-core.json
>> @@ -1567,7 +1567,7 @@
>>  # Driver specific block device options for qcow.
>>  #
>>  # @keyid:                 #optional ID of the "secret" object providing the
>> -#                         AES decryption key.
>> +#                         AES decryption key (since 2.5)
> 
> Looks like this line...
> 
>>  #
>>  # Since: 2.5
>>  ##
>> @@ -1611,6 +1611,9 @@
>>  #                         caches. The interval is in seconds. The default 
>> value
>>  #                         is 0 and it disables this feature (since 2.5)
>>  #
>> +# @keyid:                 #optional ID of the "secret" object providing the
>> +#                         AES decryption key.
> 
> ...and this line should be swapped.
> 

Also, do you want to change BlockdevOptionsQcow2 to have a base class of
BlockdevOptionsQcow, and get keyid by inheritance rather than by direct
declaration?  Doesn't matter in the long run (once my qapi patches land
that provide the information without going through an extra 'base->' layer).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]