[Qemu-devel] [PATCH v2 0/4] fw_cfg: spec update, read optimization, misc. cleanup

[Gabriel L. Somlo]

This series' main purpose is to update (and simplify) the specified
read callback behavior. An earlier standalone patch to move qemu function
call API documentation into fw_cfg.h should logically be part of the series.

Here's the summary of what each patch does:

        - Patch 1/4 is an updated version of the standalone v1 patch
          I sent out earlier; it moves all the qemu-internal host-side
          function call api documentation out of docs/specs/fw_cfg.txt,
          and into the fw_cfg.h header file, next to the prototype of
          each documented api function.

        - Patch 2/4 modifies the specified behavior of read callbacks
          (from being invoked once per byte read, to being invoked once,
           before ANY data is read, specifically once each time an item
           is selected).

        - Patch 3/4 additionally removes the now-redundant offset argument
          from the read callback prototype.

        - Finally, 4/4 consolidates (non-DMA) reads, minimizing the number
          of times redundant sanity checks are performed, particularly for
          wide (> byte) sized reads.

Comments, reviews, etc. much appreciated!

Thanks,
  Gabriel

Gabriel L. Somlo (4):
  fw_cfg: move internal function call docs to header file
  fw_cfg: amend callback behavior spec to once per select
  fw_cfg: remove offset argument from callback prototype
  fw_cfg: streamline (non-DMA) read operations

 docs/specs/fw_cfg.txt     |  85 +------------------------------
 hw/arm/virt-acpi-build.c  |   2 +-
 hw/i386/acpi-build.c      |   2 +-
 hw/nvram/fw_cfg.c         |  53 +++++++------------
 include/hw/nvram/fw_cfg.h | 127 +++++++++++++++++++++++++++++++++++++++++++++-
 trace-events              |   2 +-
 6 files changed, 147 insertions(+), 124 deletions(-)

-- 
2.4.3