[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error |
|
Date: |
Thu, 29 Oct 2015 08:31:00 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/29/2015 05:15 AM, Markus Armbruster wrote:
> Leak introduced in commit 8a4f501..710aec9, v2.4.0.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> monitor.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/monitor.c b/monitor.c
> index 301a143..c59e85b 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3862,6 +3862,7 @@ static void handle_qmp_command(JSONMessageParser
> *parser, QList *tokens)
> err_out:
> monitor_protocol_emitter(mon, data, local_err);
> qobject_decref(data);
> + error_free(local_err);
> QDECREF(input);
> QDECREF(args);
> }
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature