[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/2] aio: Use epoll in aio_poll()
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/2] aio: Use epoll in aio_poll() |
Date: |
Thu, 29 Oct 2015 17:37:39 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, Oct 26, 2015 at 02:39:40PM +0800, Fam Zheng wrote:
> v3: Remove the redundant check in aio_epoll_try_enable. [Stefan]
>
> v2: Merge aio-epoll.c into aio-posix.c. [Paolo]
> Capture some benchmark data in commit log.
>
> This series adds the ability to use epoll in aio_poll() on Linux. It's
> switched
> on in a dynamic way rather than static for two reasons: 1) when the number of
> fds is not high enough, using epoll has little advantage; 2) when an epoll
> incompatible fd needs to be handled, we need to fall back. The epoll is
> enabled when a fd number threshold is met.
>
>
>
> Fam Zheng (2):
> aio: Introduce aio_context_setup
> aio: Introduce aio-epoll.c
>
> aio-posix.c | 174
> +++++++++++++++++++++++++++++++++++++++++++++++++++-
> aio-win32.c | 4 ++
> async.c | 13 +++-
> include/block/aio.h | 14 +++++
> 4 files changed, 201 insertions(+), 4 deletions(-)
Hmm...this conflicts with aio_node_check() from "aio: introduce
aio_{disable,enable}_external".
Please rebase this on your io_{disable,enable}_external() so that nodes
are added/removed from epoll as needed for
io_{disable,enable}_external().
Then I'll apply it on top of your io_{disable,enable}_external() which
is already in my block branch.
Stefan
signature.asc
Description: PGP signature