Re: [Qemu-devel] [PATCH 03/11] trace: split trace_init_file out of trace_init_backends

[Denis V. Lunev]

On 10/29/2015 08:23 PM, Stefan Hajnoczi wrote:
> On Mon, Oct 26, 2015 at 12:10:20PM +0300, Denis V. Lunev wrote:
> > From: Paolo Bonzini <address@hidden>
> >
> > This is cleaner, and improves error reporting with -daemonize.
> >
> > Signed-off-by: Paolo Bonzini <address@hidden>
> > Signed-off-by: Denis V. Lunev <address@hidden>
> > Reviewed-by: Christian Borntraeger <address@hidden>
> > ---
> >   qemu-io.c       |  2 +-
> >   trace/control.c | 17 ++++++++++++-----
> >   trace/control.h | 13 ++++++++++++-
> >   trace/simple.c  |  6 ++----
> >   trace/simple.h  |  4 ++--
> >   vl.c            | 13 +++++++++----
> >   6 files changed, 38 insertions(+), 17 deletions(-)
> >
> > diff --git a/qemu-io.c b/qemu-io.c
> > index 269f17c..fbddf82 100644
> > --- a/qemu-io.c
> > +++ b/qemu-io.c
> > @@ -440,7 +440,7 @@ int main(int argc, char **argv)
> >               }
> >               break;
> >           case 'T':
> > -            if (!trace_init_backends(optarg, NULL)) {
> > +            if (!trace_init_backends()) {
> The previous patch dropped the 2nd argument to trace_init_backends().  I
> guess that means the previous patch doesn't compile by itself?
>
> Please move this hunk to the previous patch so that git-bisect(1) works
> (i.e. each commit builds successfully and runs).
yes, you are right.

I have mistaken fixing Paolo's patchset. This needs to be addressed.
I'll do this in a couple of hours when I'll be at home.

Den