[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v3 00/14] QMP and QObject patches
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL v3 00/14] QMP and QObject patches |
Date: |
Thu, 29 Oct 2015 13:10:51 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 10/29/2015 12:33 PM, Markus Armbruster wrote:
>> Still doesn't build with old glib:
>>
>> In file included from /Users/pm215/src/qemu-for-merges/qga/commands.c:14:
>> In file included from
>> /Users/pm215/src/qemu-for-merges/qga/guest-agent-core.h:14:
>> In file included from
>> /Users/pm215/src/qemu-for-merges/include/qemu-common.h:25:
>> /Users/pm215/src/qemu-for-merges/include/glib-compat.h:172:47: error:
>> expected ';' after expression
>> g_hash_table_replace(hash_table, key, key)
>> ^
>> ;
>>
>> I did a trial build with the typo fixed, and that is OK, so this
>> should be the last fix required, I think.
>
> Hand me the brown paper bag...
And me, for letting that slip by review even when I caught 'add (' on
the line above.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL v3 04/14] qfloat qint: Make conversion from QObject * accept null, (continued)
- [Qemu-devel] [PULL v3 04/14] qfloat qint: Make conversion from QObject * accept null, Markus Armbruster, 2015/10/29
- [Qemu-devel] [PULL v3 12/14] monitor: Turn monitor_qapi_event_state[] into a hash table, Markus Armbruster, 2015/10/29
- [Qemu-devel] [PULL v3 08/14] monitor: Simplify event throttling, Markus Armbruster, 2015/10/29
- [Qemu-devel] [PULL v3 09/14] monitor: Switch from timer_new() to timer_new_ns(), Markus Armbruster, 2015/10/29
- [Qemu-devel] [PULL v3 13/14] monitor: Throttle event VSERPORT_CHANGE separately by "id", Markus Armbruster, 2015/10/29
- [Qemu-devel] [PULL v3 05/14] qlist: Make conversion from QObject * accept null, Markus Armbruster, 2015/10/29
- [Qemu-devel] [PULL v3 14/14] docs: Document QMP event rate limiting, Markus Armbruster, 2015/10/29
- [Qemu-devel] [PULL v3 10/14] monitor: Split MonitorQAPIEventConf off MonitorQAPIEventState, Markus Armbruster, 2015/10/29
- Re: [Qemu-devel] [PULL v3 00/14] QMP and QObject patches, Peter Maydell, 2015/10/29