[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/3] armv7-m: Implement SYSRESETREQ
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/3] armv7-m: Implement SYSRESETREQ |
Date: |
Fri, 30 Oct 2015 14:16:14 -0700 |
On Sun, Oct 11, 2015 at 8:36 PM, Michael Davidsaver
<address@hidden> wrote:
> Implement the SYSRESETREQ bit of the AIRCR register
> for armv7-m (ie. cortex-m3) to trigger a GPIO out.
>
> Signed-off-by: Michael Davidsaver <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
> ---
> hw/intc/armv7m_nvic.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/hw/intc/armv7m_nvic.c b/hw/intc/armv7m_nvic.c
> index 3ec8408..6fc167e 100644
> --- a/hw/intc/armv7m_nvic.c
> +++ b/hw/intc/armv7m_nvic.c
> @@ -28,6 +28,7 @@ typedef struct {
> MemoryRegion gic_iomem_alias;
> MemoryRegion container;
> uint32_t num_irq;
> + qemu_irq sysresetreq;
> } nvic_state;
>
> #define TYPE_NVIC "armv7m_nvic"
> @@ -348,10 +349,13 @@ static void nvic_writel(nvic_state *s, uint32_t offset,
> uint32_t value)
> break;
> case 0xd0c: /* Application Interrupt/Reset Control. */
> if ((value >> 16) == 0x05fa) {
> + if (value & 4) {
> + qemu_irq_pulse(s->sysresetreq);
> + }
> if (value & 2) {
> qemu_log_mask(LOG_UNIMP, "VECTCLRACTIVE unimplemented\n");
> }
> - if (value & 5) {
> + if (value & 1) {
> qemu_log_mask(LOG_UNIMP, "AIRCR system reset
> unimplemented\n");
> }
> if (value & 0x700) {
> @@ -535,11 +539,14 @@ static void armv7m_nvic_instance_init(Object *obj)
> * value in the GICState struct.
> */
> GICState *s = ARM_GIC_COMMON(obj);
> + DeviceState *dev = DEVICE(obj);
> + nvic_state *nvic = NVIC(obj);
> /* The ARM v7m may have anything from 0 to 496 external interrupt
> * IRQ lines. We default to 64. Other boards may differ and should
> * set the num-irq property appropriately.
> */
> s->num_irq = 64;
> + qdev_init_gpio_out_named(dev, &nvic->sysresetreq, "SYSRESETREQ", 1);
> }
>
> static void armv7m_nvic_class_init(ObjectClass *klass, void *data)
> --
> 2.1.4
>
- Re: [Qemu-devel] [PATCH] armv7-m: exit on external reset request, (continued)
- Re: [Qemu-devel] [PATCH] armv7-m: exit on external reset request, Peter Maydell, 2015/10/09
- Re: [Qemu-devel] [PATCH] armv7-m: exit on external reset request, Michael Davidsaver, 2015/10/10
- Re: [Qemu-devel] [PATCH] armv7-m: exit on external reset request, Peter Crosthwaite, 2015/10/09
- Re: [Qemu-devel] [PATCH] armv7-m: exit on external reset request, Michael Davidsaver, 2015/10/09
- Re: [Qemu-devel] [PATCH] armv7-m: exit on external reset request, Michael Davidsaver, 2015/10/10
- [Qemu-devel] [PATCH v2] armv7-m: exit on external reset request, Michael Davidsaver, 2015/10/10
- Re: [Qemu-devel] [PATCH v2] armv7-m: exit on external reset request, Peter Crosthwaite, 2015/10/15
- [Qemu-devel] [PATCH v3 3/3] stellaris: exit on external reset request, Michael Davidsaver, 2015/10/11
- Re: [Qemu-devel] [PATCH v3 3/3] stellaris: exit on external reset request, Peter Crosthwaite, 2015/10/30
- [Qemu-devel] [PATCH v3 2/3] armv7-m: Implement SYSRESETREQ, Michael Davidsaver, 2015/10/11
- Re: [Qemu-devel] [PATCH v3 2/3] armv7-m: Implement SYSRESETREQ,
Peter Crosthwaite <=
- [Qemu-devel] [PATCH v3 1/3] armv7-m: Return DeviceState* from armv7m_init(), Michael Davidsaver, 2015/10/11
- Re: [Qemu-devel] [PATCH v3 1/3] armv7-m: Return DeviceState* from armv7m_init(), Peter Crosthwaite, 2015/10/30
- Re: [Qemu-devel] [PATCH v3 1/3] armv7-m: Return DeviceState* from armv7m_init(), Peter Crosthwaite, 2015/10/30
- Re: [Qemu-devel] [PATCH v3 1/3] armv7-m: Return DeviceState* from armv7m_init(), Peter Maydell, 2015/10/30
Re: [Qemu-devel] [PATCH] Exit on reset for armv7-m, Peter Crosthwaite, 2015/10/08