[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/6] ui/curses: Fix monitor color with -curses when 2
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 1/6] ui/curses: Fix monitor color with -curses when 256 colors |
Date: |
Tue, 3 Nov 2015 11:01:26 +0100 |
From: OGAWA Hirofumi <address@hidden>
If TERM=xterm-256color, COLOR_PAIRS==256 and monitor passes chtype
like 0x74xx. Then, the code uses uninitialized color pair. As result,
monitor uses black for both of fg and bg color, i.e. terminal is
filled by black.
To fix, this initialize above than 64 with default color (fg=white,bg=black).
FIXME: on 256 color, curses may be possible better vga color emulation.
Signed-off-by: OGAWA Hirofumi <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/curses.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/ui/curses.c b/ui/curses.c
index 8edb038..35edd5e 100644
--- a/ui/curses.c
+++ b/ui/curses.c
@@ -341,8 +341,13 @@ static void curses_setup(void)
nodelay(stdscr, TRUE); nonl(); keypad(stdscr, TRUE);
start_color(); raw(); scrollok(stdscr, FALSE);
- for (i = 0; i < 64; i ++)
+ for (i = 0; i < 64; i++) {
init_pair(i, colour_default[i & 7], colour_default[i >> 3]);
+ }
+ /* Set default color for more than 64. (monitor uses 0x74xx for example) */
+ for (i = 64; i < COLOR_PAIRS; i++) {
+ init_pair(i, COLOR_WHITE, COLOR_BLACK);
+ }
}
static void curses_keyboard_setup(void)
--
1.8.3.1
- [Qemu-devel] [PULL 0/6] ui patch queue, Gerd Hoffmann, 2015/11/03
- [Qemu-devel] [PULL 1/6] ui/curses: Fix monitor color with -curses when 256 colors,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 6/6] vnc: fix bug: vnc server can't start when 'to' is specified, Gerd Hoffmann, 2015/11/03
- [Qemu-devel] [PULL 4/6] ui/opengl: Reduce build required libraries for opengl, Gerd Hoffmann, 2015/11/03
- [Qemu-devel] [PULL 2/6] ui/curses: Support line graphics chars on -curses mode, Gerd Hoffmann, 2015/11/03
- [Qemu-devel] [PULL 5/6] vnc: allow fall back to RAW encoding, Gerd Hoffmann, 2015/11/03
- [Qemu-devel] [PULL 3/6] ui/curses: Fix pageup/pagedown on -curses, Gerd Hoffmann, 2015/11/03
- Re: [Qemu-devel] [PULL 0/6] ui patch queue, Peter Maydell, 2015/11/03