qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 06/35] acpi: add aml_method_serialized


From: Xiao Guangrong
Subject: Re: [Qemu-devel] [PATCH v7 06/35] acpi: add aml_method_serialized
Date: Tue, 3 Nov 2015 21:27:29 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0



On 11/03/2015 08:30 PM, Igor Mammedov wrote:
On Mon,  2 Nov 2015 17:13:08 +0800
Xiao Guangrong <address@hidden> wrote:

It avoid explicit Mutex and will be used by NVDIMM ACPI

Signed-off-by: Xiao Guangrong <address@hidden>
---
  hw/acpi/aml-build.c         | 26 ++++++++++++++++++++++++--
  include/hw/acpi/aml-build.h |  1 +
  2 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index 9f792ab..8bee8b2 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -696,14 +696,36 @@ Aml *aml_while(Aml *predicate)
  }

  /* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefMethod */
-Aml *aml_method(const char *name, int arg_count)
+static Aml *__aml_method(const char *name, int arg_count, bool serialized)
We don't have many users of aml_method() yet, so I'd prefer to have a single
vs multiple function call:

I suggest to do something like:
typedef enum {
     AML_NONSERIALIZED = 0,
     AML_SERIALIZED = 1,
} AmlSerializeRule;

aml_method(const char *name, AmlSerializeRule rule, int synclevel);

with current users fixed up with AML_NONSERIALIZED argument.

Okay. It looks good to me, will follow it.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]