Re: [Qemu-devel] [PATCH v9 05/27] qapi: More tests of alternate output

[Markus Armbruster]

Suggest "qapi: Test alternate output visitor with boxed type"

Eric Blake <address@hidden> writes:

> The testsuite was only covering that we could output a built-in
> branch of an alternate; make sure that things still work even

Well, 'str' is built-in, too.  "'int' branch"?

> when a branch involves allocation, to ensure that we don't leak
> when run under valgrind.

More pedantry: we'd leak when not running under valgrind just as much.

> Update to modern style of g_new0() over g_malloc0() while
> touching it.
>
> Signed-off-by: Eric Blake <address@hidden>

Patch looks good.